lprimak commented on code in PR #2772:
URL: https://github.com/apache/shiro/pull/2772#discussion_r3421900734
##########
integration-tests/jakarta-ee/src/main/java/org/apache/shiro/testing/jakarta/ee/PropertyRealm.java:
##########
@@ -56,11 +56,11 @@ protected void processUserDefinitions(Map<String, String>
userDefs) {
SimpleAccount account = getUser(username);
if (account == null) {
- var pc = new SimplePrincipalCollection();
- pc.add(username, getName());
- pc.add(5, getName());
- pc.add(new PropertyPrincipal(username), getName());
- account = new SimpleAccount(pc, password, getName());
+ var principalBuilder = new
ImmutablePrincipalCollection.Builder();
Review Comment:
var was introduced in JDK 11 so "var everywhere" isn't really in scope here
since this is upgrade 11->17.
Also I am not a big fan of var everywhere, but of course it's useful in
places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
