lprimak commented on code in PR #2772:
URL: https://github.com/apache/shiro/pull/2772#discussion_r3422184685
##########
core/src/main/java/org/apache/shiro/realm/ldap/LdapUtils.java:
##########
@@ -69,8 +69,8 @@ public static void closeContext(LdapContext ctx) {
* @throws javax.naming.NamingException if there is an LDAP error while
reading the values.
*/
public static Collection<String> getAllAttributeValues(Attribute attr)
throws NamingException {
- Set<String> values = new HashSet<String>();
- NamingEnumeration ne = null;
+ Set<String> values = new HashSet<>();
Review Comment:
For example, here we want to use base class `Set<>` instead of `HasSet<>`
hence, var would change functionality, so var is (arguably) not appropriate here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
