rombert commented on code in PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-commons-json/pull/2#discussion_r1526401966
##########
pom.xml:
##########
@@ -79,55 +127,73 @@
<groupId>javax.jcr</groupId>
<artifactId>jcr</artifactId>
<version>2.0</version>
- <optional>true</optional>
+ <optional>true</optional>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
+ <scope>provided</scope>
</dependency>
<dependency>
- <!-- A recent version is required to use Sling mocks in tests, if
that's a problem we'll need to change them -->
+ <!-- A recent version is required to use Sling mocks in
tests, if that's a problem we'll need to change them -->
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.api</artifactId>
<version>2.3.0</version>
<optional>true</optional>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.commons.testing</artifactId>
<version>2.0.22</version>
<scope>test</scope>
<exclusions>
- <exclusion>
Review Comment:
Please revert this whitespace-only change, it makes checking the history
more difficult.
##########
pom.xml:
##########
@@ -79,55 +127,73 @@
<groupId>javax.jcr</groupId>
<artifactId>jcr</artifactId>
<version>2.0</version>
- <optional>true</optional>
+ <optional>true</optional>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
+ <scope>provided</scope>
</dependency>
<dependency>
- <!-- A recent version is required to use Sling mocks in tests, if
that's a problem we'll need to change them -->
Review Comment:
Please revert this whitespace-only change, it makes checking the history
more difficult.
##########
pom.xml:
##########
@@ -9,68 +9,116 @@
License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
CONDITIONS
OF ANY KIND, either express or implied. See the License for the
specific
language governing permissions and limitations under the License. -->
-<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.sling</groupId>
- <artifactId>sling</artifactId>
- <version>30</version>
+ <artifactId>sling-bundle-parent</artifactId>
+ <version>52</version>
<relativePath />
</parent>
<artifactId>org.apache.sling.commons.json</artifactId>
- <packaging>bundle</packaging>
<version>2.0.21-SNAPSHOT</version>
<name>Apache Sling JSON Library</name>
<description>Apache Sling JSON Library</description>
<scm>
-
<connection>scm:svn:http://svn.apache.org/repos/asf/sling/trunk/bundles/commons/json</connection>
-
<developerConnection>scm:svn:https://svn.apache.org/repos/asf/sling/trunk/bundles/commons/json</developerConnection>
-
<url>http://svn.apache.org/viewvc/sling/trunk/bundles/commons/json</url>
+
<connection>scm:git:https://github.com/apache/sling-org-apache-sling-commons-json</connection>
+
<developerConnection>scm:git:https://github.com/apache/sling-org-apache-sling-commons-json</developerConnection>
+
<url>https://github.com/apache/sling-org-apache-sling-commons-json</url>
</scm>
+ <properties>
Review Comment:
These are not needed. If you need to override the default Java version, set
the `sling.java.version` property to `8`.
##########
pom.xml:
##########
@@ -79,55 +127,73 @@
<groupId>javax.jcr</groupId>
<artifactId>jcr</artifactId>
<version>2.0</version>
- <optional>true</optional>
Review Comment:
Please revert this whitespace-only change, it makes checking the history
more difficult.
##########
.gitignore:
##########
@@ -0,0 +1,6 @@
+.vscode
+target
+src/test/java/org/apache/sling/commons/json/CVE.java
Review Comment:
Please use a standard .gitignore file from one of our repos, e.g.
https://github.com/apache/sling-org-apache-sling-api/blob/master/.gitignore .
This makes it compatible with multiple IDEs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
