RemoLiechti commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-commons-json/pull/2#issuecomment-2006497233
> * whitespace pom.xml changes addressed done > * inline comments about the set/get tidy methods see my comment on the isTidy() added single warning log when API is used > * listing the changes you made to the external libraries so we don't forget how to do this if we need to apply updates again. Given how much you added, I think a single external file would work, either README.md, package-info.java, or whatever you prefer Done in readme.md > * making sure the required Java version is 8; it was previously 7 but we don't need to require 7 IMO. However, the bundle built from your PR currently requires Java 11 which is not desired `Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=11))"` done, is now Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))" > * updating the LICENSE/NOTICE file as per https://www.apache.org/legal/resolved#handling-public-domain-licensed-works ; feel free to leave this out if you are unable to figure out in time, we can probably ask for guidance Added licence and notice file according to https://infra.apache.org/licensing-howto.html also put JSONML, JSONMLParserConfioguration and Property to package-private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
