nscendoni commented on code in PR #14:
URL:
https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/14#discussion_r2042408201
##########
pom.xml:
##########
@@ -221,12 +229,16 @@
<repositoryUrl>file://${project.build.directory}/artifacts</repositoryUrl>
</repositoryUrls>
<launcherArguments>
+ <vm-options>
Review Comment:
I commented the vm-options. I use them when I start sling with `mvn
feature-launcher:start feature-launcher:stop
-Dfeature-launcher.waitForInput=true`. It looks to me that a new profile cannot
help in this situation when we do not need to make a real build. When added a
new `debug` profile and started Sling with: `mvn feature-launcher:start
feature-launcher:stop -Dfeature-launcher.waitForInput=true -Pdebug` the
additional parameters were not taken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
