anchela commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/14#issuecomment-2827707233
@nscendoni , @rombert , while working on the PR to address my findings I spotted a bigger issue with OAuthTokens, which has both accessToken and refreshToken to be marked as Nullable. -> but then code that is accessing it doesn't check for null and passes the value to calls that don't accept null values. I marked all i spotted with a fat FIXME comment. ideally, we would not allow for null-values when creating OAuthTokens, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
