This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.5 by this push:
     new 16c9f8642ac [SPARK-44750][PYTHON][CONNECT][TESTS][FOLLOW-UP] Avoid 
creating session twice in `SparkConnectSessionWithOptionsTest`
16c9f8642ac is described below

commit 16c9f8642ac55d833fced0f7a7aba9b326f59243
Author: Ruifeng Zheng <[email protected]>
AuthorDate: Fri Sep 1 10:01:36 2023 -0700

    [SPARK-44750][PYTHON][CONNECT][TESTS][FOLLOW-UP] Avoid creating session 
twice in `SparkConnectSessionWithOptionsTest`
    
    ### What changes were proposed in this pull request?
    Avoid creating session twice in `SparkConnectSessionWithOptionsTest`
    
    ### Why are the changes needed?
    the session created in `ReusedConnectTestCase#setUpClass` is not used, so 
no need to inherit
    
    ### Does this PR introduce _any_ user-facing change?
    no, test-only
    
    ### How was this patch tested?
    ci
    
    ### Was this patch authored or co-authored using generative AI tooling?
    no
    
    Closes #42747 from zhengruifeng/minor_test_ut.
    
    Authored-by: Ruifeng Zheng <[email protected]>
    Signed-off-by: Dongjoon Hyun <[email protected]>
    (cherry picked from commit 8c27de68756d4b0e5940211340a0b323d808aead)
    Signed-off-by: Dongjoon Hyun <[email protected]>
---
 python/pyspark/sql/tests/connect/test_connect_basic.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/pyspark/sql/tests/connect/test_connect_basic.py 
b/python/pyspark/sql/tests/connect/test_connect_basic.py
index 54911c09b6f..2904eb42587 100644
--- a/python/pyspark/sql/tests/connect/test_connect_basic.py
+++ b/python/pyspark/sql/tests/connect/test_connect_basic.py
@@ -3347,7 +3347,7 @@ class SparkConnectSessionTests(ReusedConnectTestCase):
             self.assertIn("Create a new SparkSession is only supported with 
SparkConnect.", str(e))
 
 
-class SparkConnectSessionWithOptionsTest(ReusedConnectTestCase):
+class SparkConnectSessionWithOptionsTest(unittest.TestCase):
     def setUp(self) -> None:
         self.spark = (
             PySparkSession.builder.config("string", "foo")


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to