This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new e86849a8432 [SPARK-45037][INFRA] Upload unit tests log files for
timeouted cancel
e86849a8432 is described below
commit e86849a84323bced40147bbea20eeb72924b11ca
Author: Kent Yao <[email protected]>
AuthorDate: Fri Sep 1 10:09:16 2023 -0700
[SPARK-45037][INFRA] Upload unit tests log files for timeouted cancel
### What changes were proposed in this pull request?
We currently upload ut logs on failures, while if there is a canceled
state, there could be problems, too. We need those logs for bug hunting.
### Why are the changes needed?
There may be evidence of a timeout cancellation in the logs.
reference:
https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
by github actions
### Was this patch authored or co-authored using generative AI tooling?
no
Closes #42756 from yaooqinn/SPARK-45037.
Authored-by: Kent Yao <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.github/workflows/build_and_test.yml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/.github/workflows/build_and_test.yml
b/.github/workflows/build_and_test.yml
index c0c21c7cb6e..beb5a7772b7 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -283,7 +283,7 @@ jobs:
name: test-results-${{ matrix.modules }}-${{ matrix.comment }}-${{
matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
- if: failure()
+ if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-${{ matrix.modules }}-${{ matrix.comment }}-${{
matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
@@ -470,7 +470,7 @@ jobs:
name: test-results-${{ matrix.modules }}--8-${{ inputs.hadoop
}}-hive2.3
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
- if: failure()
+ if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-${{ matrix.modules }}--8-${{ inputs.hadoop
}}-hive2.3
@@ -961,7 +961,7 @@ jobs:
name: test-results-tpcds--8-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
- if: failure()
+ if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-tpcds--8-${{ inputs.hadoop }}-hive2.3
@@ -1028,7 +1028,7 @@ jobs:
name: test-results-docker-integration--8-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
- name: Upload unit tests log files
- if: failure()
+ if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: unit-tests-log-docker-integration--8-${{ inputs.hadoop }}-hive2.3
@@ -1103,7 +1103,7 @@ jobs:
eval $(minikube docker-env)
build/sbt -Psparkr -Pkubernetes -Pvolcano
-Pkubernetes-integration-tests -Dspark.kubernetes.test.driverRequestCores=0.5
-Dspark.kubernetes.test.executorRequestCores=0.2
-Dspark.kubernetes.test.volcanoMaxConcurrencyJobNum=1 -Dtest.exclude.tags=local
"kubernetes-integration-tests/test"
- name: Upload Spark on K8S integration tests log files
- if: failure()
+ if: ${{ !success() }}
uses: actions/upload-artifact@v3
with:
name: spark-on-kubernetes-it-log
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
