nchammas commented on code in PR #699:
URL: https://github.com/apache/spark-website/pull/699#discussion_r3729762693


##########
.github/actions/build-html/action.yml:
##########
@@ -0,0 +1,22 @@
+name: Build HTML
+
+description: Set up Ruby and run the Jekyll build.
+
+inputs:
+  ruby-version:
+    description: Ruby version to use.
+    required: false
+    default: "3.4"
+
+runs:
+  using: composite
+  steps:
+  - name: Set up Ruby and Bundler
+    uses: ruby/setup-ruby@v1
+    with:
+      ruby-version: ${{ inputs.ruby-version }}

Review Comment:
   Gemfile.lock is [already 
committed](https://github.com/apache/spark-website/blob/asf-site/Gemfile.lock). 
This is so that the Jekyll build uses a stable set of dependencies.
   
   The Ruby version is set by the default on L9, unless overridden by the 
workflow calling this action. It would only change by a deliberate update to 
the workflows.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to