nchammas commented on PR #699: URL: https://github.com/apache/spark-website/pull/699#issuecomment-5838560770
> The deleted doc_gen workflow captured Jekyll stderr and failed on messages outside its allowlist, while the shared replacement action only checks the bundle exec jekyll build exit status. Was dropping that warning gate intentional? Yes, intentional. Jekyll reports its exit status correctly, and failing on messages sent on stderr isn't something we do anywhere else. It's not clear to me why this was done in the first place, and the discussion on #316 doesn't add any clarity either. > I don't see a merge-method rule established by this PR's code or description. Please use the spark-website maintainer convention for the merge itself; someone with authority over that repository policy should confirm whether squash-and-merge is acceptable. Hmm, I'm not sure what prompted this comment. But we discussed this [on the dev list][1] and I made the corresponding change in #707. All spark-website PRs are henceforth merged only using GitHub's "Squash and merge" button. [1]: https://lists.apache.org/thread/zl37onhh2y2y9rxvpw38f3srxft0bn4c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
