Repository: storm Updated Branches: refs/heads/1.1.x-branch 3929c75bf -> de731941d
STORM-2705: DRPCSpout should not sleep itself if no request was fetched as the ISpoutWaitStrategy handles this case. Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/5ae07c4e Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/5ae07c4e Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/5ae07c4e Branch: refs/heads/1.1.x-branch Commit: 5ae07c4ec94b75e28401bc0c2ef5d11d5ee59037 Parents: 3929c75 Author: sakanaou <[email protected]> Authored: Thu Aug 24 09:58:42 2017 +0200 Committer: Jungtaek Lim <[email protected]> Committed: Fri Aug 25 14:45:47 2017 +0900 ---------------------------------------------------------------------- storm-core/src/jvm/org/apache/storm/drpc/DRPCSpout.java | 6 ------ 1 file changed, 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/storm/blob/5ae07c4e/storm-core/src/jvm/org/apache/storm/drpc/DRPCSpout.java ---------------------------------------------------------------------- diff --git a/storm-core/src/jvm/org/apache/storm/drpc/DRPCSpout.java b/storm-core/src/jvm/org/apache/storm/drpc/DRPCSpout.java index 791fc91..e95e377 100644 --- a/storm-core/src/jvm/org/apache/storm/drpc/DRPCSpout.java +++ b/storm-core/src/jvm/org/apache/storm/drpc/DRPCSpout.java @@ -170,7 +170,6 @@ public class DRPCSpout extends BaseRichSpout { @Override public void nextTuple() { - boolean gotRequest = false; if(_local_drpc_id==null) { int size; synchronized (_clients) { @@ -193,7 +192,6 @@ public class DRPCSpout extends BaseRichSpout { returnInfo.put("id", req.get_request_id()); returnInfo.put("host", client.getHost()); returnInfo.put("port", client.getPort()); - gotRequest = true; _collector.emit(new Values(req.get_func_args(), JSONValue.toJSONString(returnInfo)), new DRPCMessageId(req.get_request_id(), i)); break; } @@ -218,7 +216,6 @@ public class DRPCSpout extends BaseRichSpout { returnInfo.put("id", req.get_request_id()); returnInfo.put("host", _local_drpc_id); returnInfo.put("port", 0); - gotRequest = true; _collector.emit(new Values(req.get_func_args(), JSONValue.toJSONString(returnInfo)), new DRPCMessageId(req.get_request_id(), 0)); } } catch (AuthorizationException aze) { @@ -228,9 +225,6 @@ public class DRPCSpout extends BaseRichSpout { } } } - if(!gotRequest) { - Utils.sleep(1); - } } @Override
