This is an automated email from the ASF dual-hosted git repository.

rabreu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/storm.git


The following commit(s) were added to refs/heads/master by this push:
     new 9e020628b Replace e.printStackTrace() with SLF4J logging in 
ConfigurableTopology#submit (#8413)
9e020628b is described below

commit 9e020628b986c5301c865d65eeb37906bd9d77dc
Author: Ironankit525 <[email protected]>
AuthorDate: Mon Mar 2 15:04:50 2026 +0530

    Replace e.printStackTrace() with SLF4J logging in 
ConfigurableTopology#submit (#8413)
---
 .../src/jvm/org/apache/storm/topology/ConfigurableTopology.java      | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/storm-client/src/jvm/org/apache/storm/topology/ConfigurableTopology.java 
b/storm-client/src/jvm/org/apache/storm/topology/ConfigurableTopology.java
index b80ac19bc..b3f52a0be 100644
--- a/storm-client/src/jvm/org/apache/storm/topology/ConfigurableTopology.java
+++ b/storm-client/src/jvm/org/apache/storm/topology/ConfigurableTopology.java
@@ -35,6 +35,8 @@ import 
org.apache.storm.shade.org.yaml.snakeyaml.LoaderOptions;
 import org.apache.storm.shade.org.yaml.snakeyaml.Yaml;
 import org.apache.storm.shade.org.yaml.snakeyaml.constructor.SafeConstructor;
 import org.apache.storm.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * Extensions of this class takes a reference to one or more configuration 
files. The main() method should call ConfigurableTopology.start()
@@ -60,6 +62,7 @@ import org.apache.storm.utils.Utils;
  * </pre>
  **/
 public abstract class ConfigurableTopology {
+    private static final Logger LOG = 
LoggerFactory.getLogger(ConfigurableTopology.class);
 
     protected Config conf = new Config();
 
@@ -120,7 +123,7 @@ public abstract class ConfigurableTopology {
             StormSubmitter.submitTopology(name, conf,
                                           builder.createTopology());
         } catch (Exception e) {
-            e.printStackTrace();
+            LOG.error("Failed to submit topology {}", name, e);
             return -1;
         }
         return 0;

Reply via email to