This is an automated email from the ASF dual-hosted git repository.

rzo1 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/storm.git


The following commit(s) were added to refs/heads/master by this push:
     new 6b1ab77be Add missing logging to TridentBoltExecutor on tuple count 
mismatch failures
6b1ab77be is described below

commit 6b1ab77beafa858ee4d3b838d034b9c42debaba6
Author: Ankit Kumar <[email protected]>
AuthorDate: Mon Mar 2 03:11:13 2026 +0530

    Add missing logging to TridentBoltExecutor on tuple count mismatch failures
---
 .../jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git 
a/storm-client/src/jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java
 
b/storm-client/src/jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java
index 11b61fbc3..9863c36fc 100644
--- 
a/storm-client/src/jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java
+++ 
b/storm-client/src/jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java
@@ -40,9 +40,13 @@ import org.apache.storm.tuple.Values;
 import org.apache.storm.utils.RotatingMap;
 import org.apache.storm.utils.TupleUtils;
 import org.apache.storm.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class TridentBoltExecutor implements IRichBolt {
     public static final String COORD_STREAM_PREFIX = "$coord-";
+    private static final Logger LOG = 
LoggerFactory.getLogger(TridentBoltExecutor.class);
+
     Map<GlobalStreamId, String> batchGroupIds;
     Map<String, CoordSpec> coordSpecs;
     Map<String, CoordCondition> coordConditions;
@@ -160,7 +164,8 @@ public class TridentBoltExecutor implements IRichBolt {
             if (tracked.receivedTuples == tracked.expectedTupleCount) {
                 finishBatch(tracked, tuple);
             } else {
-                //TODO: add logging that not all tuples were received
+                LOG.warn("Failing batch {}: expected {} tuples but only 
received {}", 
+                         tracked.info.batchId, tracked.expectedTupleCount, 
tracked.receivedTuples);
                 failBatch(tracked);
                 collector.fail(tuple);
                 failed = true;

Reply via email to