yuanzac commented on a change in pull request #249: SUBMARINE-455. Support
find/patch/delete job in submarine-server REST
URL: https://github.com/apache/submarine/pull/249#discussion_r399057552
##########
File path:
submarine-server/server-api/src/main/java/org/apache/submarine/server/api/JobSubmitter.java
##########
@@ -38,4 +41,35 @@
*/
String getSubmitterType();
+ /**
+ * Create job with job spec
+ * @param jobSpec job spec
+ * @return object
+ * @throws InvalidSpecException invalid spec
+ */
+ Job createJob(JobSpec jobSpec) throws InvalidSpecException;
+
+ /**
+ * Find job by job spec
+ * @param jobSpec job spec
+ * @return object
+ * @throws InvalidSpecException invalid spec
+ */
+ Job findJob(JobSpec jobSpec) throws InvalidSpecException;
Review comment:
We'd better change findJob() to getJob(), as jobhandler uses getJob().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
