tangzhankun commented on a change in pull request #323:
URL: https://github.com/apache/submarine/pull/323#discussion_r443928052
##########
File path:
submarine-sdk/pysubmarine/submarine/experiment/api/experiment_client.py
##########
@@ -110,19 +113,19 @@ def delete_experiment(self, id):
response = self.experiment_api.delete_experiment(id)
return response.result
- def get_log(self, id, master=True):
+ def get_log(self, id, master=False):
"""
Get training logs of the experiment.
By default only get the logs of Pod that has labels 'job-role: master'.
- :param master: By default get pod with label 'job-role: master' pod if
True.
+ :param master: Get pod with label 'job-role: master' pod if True.
Review comment:
The description of "master" param seems confusing. I thought get_log(id)
will get all pod's log, and get_log(id, master=false) will discard the master
pod log.
But per the description, get_log(id, master=True) will get a master log.
This is confusing.
> Get pod with label 'job-role: master' pod if True.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
