tangzhankun commented on a change in pull request #323:
URL: https://github.com/apache/submarine/pull/323#discussion_r444141005
##########
File path:
submarine-sdk/pysubmarine/submarine/experiment/api/experiment_client.py
##########
@@ -110,19 +113,19 @@ def delete_experiment(self, id):
response = self.experiment_api.delete_experiment(id)
return response.result
- def get_log(self, id, master=True):
+ def get_log(self, id, master=False):
"""
Get training logs of the experiment.
By default only get the logs of Pod that has labels 'job-role: master'.
- :param master: By default get pod with label 'job-role: master' pod if
True.
+ :param master: Get pod with label 'job-role: master' pod if True.
Review comment:
How about this?
```Python
"""
get_logs(self, id, onlyMaster=False)
Get training logs of all pod of the experiment.
By default get all the logs of Pod
:param id: experiment id
:param onlyMaster: By default include pod log of "master" which might be
Tensorflow PS/Chief or PyTroch master
:return: str: pods logs
"""
```
get_logs(id) will get all pod logs
get_long(id, onlyMaster=True) will only get master pod's log
@pingsutw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
