noidname01 commented on a change in pull request #598:
URL: https://github.com/apache/submarine/pull/598#discussion_r645931684
##########
File path: submarine-cloud-v2/controller.go
##########
@@ -1271,16 +1269,7 @@ func (c *Controller) syncHandler(workqueueItem
WorkQueueItem) error {
return err
}
- // Port-forwarding
- // TODO:
- // (1) multi-tenant port-forwarding
- // (2) Basic operations: on/off/modify (change port)
- // (3) in-cluster
- if action == ADD {
- if !c.incluster {
Review comment:
Oh I found that there's something I didn't notice, I'll fix it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
