[GitHub] [submarine] kevin85421 commented on a change in pull request #598: SUBMARINE-835. Exposing method modified

[GitBox]

kevin85421 commented on a change in pull request #598:
URL: https://github.com/apache/submarine/pull/598#discussion_r646143397



##########
File path: submarine-cloud-v2/README.md
##########
@@ -57,21 +64,25 @@ go build -o submarine-operator
 kubectl create ns submarine-admin
 kubectl apply -n submarine-admin -f artifacts/examples/example-submarine.yaml
 
-# Step3: "submarine-operator" will perform port-forwarding automatically.
+# Step3: Exposing Service
+# Using minikube ip + NodePort
+$ minikube ip  # you'll get the IP address of minikube, ex: 192.168.49.2
 
-# Step4: View workbench (127.0.0.1:32080) with your web browser
+# Step4: View workbench
+# http://{minikube ip}:32080, ex: http://192.168.49.2:32080

Review comment:
       In the following figure, the branch is at commit "SUBMARINE-841. Modify 
hard-coded URLs in E2E test to soft-coded URLs".
   <img width="581" alt="截圖 2021-06-06 下午10 44 34" 
src="https://user-images.githubusercontent.com/20109646/120928880-1d066400-c719-11eb-8bda-d2f29af4d2b4.png";>
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org