FatalLin commented on pull request #735: URL: https://github.com/apache/submarine/pull/735#issuecomment-911246637
@lowc1012 I just checked the current flow and found out it would be pretty complicate if we move the codes into NotebookUtils. current flow: `NotebookManager -> k8sSubmitter -> NotebookUtil` if we want to move the codes into NotebookUtil, notebookUtil will need to call k8sSubmitter to get further details of pods and event which will cause a calling loop, and I'm don't think it's a good design for us. I had an alternative solution is moving part of the codes into NotebookManager, like the notebookManager will check is pod waiting due to pulling operation(and this is also a specific case for k8sSubmitter, even yarn is no longer supported). How do you think about these? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
