FatalLin commented on pull request #735: URL: https://github.com/apache/submarine/pull/735#issuecomment-912654076
@kevin85421 @pingsutw @lowc1012 Hi guys, thanks for the discussion in the last two days! I just pushed the last commit of this PR, and this should be the final version of it. per discussion with Kai-Hsun, we added a new Map property into Notebook Meta Class, which is also could be leveraged later if we allow user to enter their own label from front-end. We put the notebookId into the label properties, and all the operation depends on the name has been modified, they are depending on the notebookId now. I also added the check while notebook creating operation to make sure the notebook name is unique. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
