cdmikechen commented on PR #994:
URL: https://github.com/apache/submarine/pull/994#issuecomment-1246082608

   @huang06 
   Hi~ I've checked the python checks failed in 
submarine-sdk/pysubmarine/tests/tracking/test_tracking.py. And you need to 
change the parameters of `save_model`, the current ones are indeed wrong.
   ```python
       @pytest.mark.skipif(tensorflow.version.VERSION < "2.0", reason="using 
tensorflow 2")
       def test_save_model(self):
           input_arr = tensorflow.random.uniform((1, 5))
           model = LinearNNModel()
           model(input_arr)
           self.client.save_model(model, "tensorflow", REGISTERED_MODEL_NAME)
           self.client.save_model(model, "tensorflow", REGISTERED_MODEL_NAME)
           # Validate model_versions
           model_versions = 
self.model_registry.list_model_versions(REGISTERED_MODEL_NAME)
           assert len(model_versions) == 2
           assert model_versions[0].name == REGISTERED_MODEL_NAME
           assert model_versions[0].version == 1
           assert model_versions[1].name == REGISTERED_MODEL_NAME
           assert model_versions[1].version == 2
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to