cdmikechen commented on code in PR #994:
URL: https://github.com/apache/submarine/pull/994#discussion_r971398834
##########
submarine-sdk/pysubmarine/setup.py:
##########
@@ -28,41 +28,41 @@
packages=find_packages(exclude=["tests", "tests.*"]),
package_data={"submarine.cli.config": ["cli_config.yaml"]},
install_requires=[
- "six>=1.10.0",
- "numpy==1.19.2",
+ "numpy",
"pandas",
"sqlalchemy>=1.4.0",
"sqlparse",
"pymysql",
- "requests==2.26.0",
+ "requests",
"urllib3>=1.15.1",
"certifi>=14.05.14",
"python-dateutil>=2.5.3",
"pyarrow>=6.0.1",
"boto3>=1.17.58",
- "click==8.0.3",
- "rich==10.15.2",
- "dacite==1.6.0",
- "dataclasses>=0.6",
- "pyaml==21.10.1",
+ "click>=8.1.0",
+ "rich",
+ "dacite",
+ "pyaml",
],
extras_require={
- "tf": ["tensorflow==1.15.0", "protobuf<=3.20.1"],
+ "tf": ["tensorflow==1.15.5", "numpy>=1.16.0,<1.19.0",
"protobuf>=3.6.1,<=3.20.1"],
"tf2": [
- "tensorflow==2.6.0",
+ "tensorflow>=2.6.0,<2.10.0",
+ "numpy>=1.14.5",
+ "keras>=2.6.0",
+ "protobuf>=3.9.2,<3.20",
Review Comment:
`protobuf` in tf2 should also be limited to 3.20.1 ?
I don't know what the latest versions of all these dependencies are yet, and
it may take me some time to confirm whether there is some potential impact of
the interdependencies between these versions. Or if you have time on your side
could you run a test locally?
What do you think? @pingsutw @KUAN-HSUN-LI
##########
website/versioned_docs/version-0.6.0/userDocs/yarn/docker/pytorch/with-cifar10-models/cifar10_tutorial.py:
##########
@@ -71,7 +71,12 @@
Using ``torchvision``, it’s extremely easy to load CIFAR10.
"""
+import matplotlib.pyplot as plt
Review Comment:
These codes under 0.6.0 documents `website/versioned_docs/version-0.6.0/**`
should also be rolled back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
