cdmikechen commented on code in PR #999: URL: https://github.com/apache/submarine/pull/999#discussion_r982955997
########## helm-charts/submarine/Chart.yaml: ########## @@ -23,6 +23,9 @@ version: 0.8.0-SNAPSHOT icon: https://submarine.apache.org/assets/themes/submarine/img/submarine_white_logo.png dependencies: - name: training-operator - version: "0.1.0" + version: "0.7.0" - name: notebook-controller version: "0.1.0" + - name: seldon-core-operator + version: "1.10.0" + repository: https://storage.googleapis.com/seldon-charts Review Comment: If the user already has installed `seldon`, I think we can add a condition to make helm not install this dependency. For example: ```yaml condition: seldon-core-operator.enabled ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
