cdmikechen commented on code in PR #999:
URL: https://github.com/apache/submarine/pull/999#discussion_r991716319
##########
helm-charts/submarine/templates/seldon-gateway.yaml:
##########
@@ -18,7 +18,7 @@ apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: seldon-gateway
- namespace: istio-system
+ namespace: default
Review Comment:
please use {{ .Release.Namespace }}
##########
helm-charts/submarine/Chart.yaml:
##########
@@ -23,6 +23,10 @@ version: 0.8.0-SNAPSHOT
icon:
https://submarine.apache.org/assets/themes/submarine/img/submarine_white_logo.png
dependencies:
- name: training-operator
- version: "0.1.0"
+ version: "0.7.0"
- name: notebook-controller
version: "0.1.0"
+ - name: seldon-core-operator
Review Comment:
I think we should add the `helm dep update` to
https://github.com/apache/submarine/blob/master/website/docs/gettingStarted/quickstart.md
and add the dependency description.
##########
helm-charts/submarine/templates/seldon-secret.yaml:
##########
@@ -18,7 +18,7 @@ apiVersion: v1
kind: Secret
metadata:
name: submarine-serve-secret
- namespace: submarine-user-test
+ namespace: default
Review Comment:
we should not move and changed this file, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
