Author: markphip
Date: Thu Dec 17 15:21:45 2009
New Revision: 891758
URL: http://svn.apache.org/viewvc?rev=891758&view=rev
Log:
JavaHL: Improve test by throwing an exception when API call fails rather than
catching the exception and reporting the test as a failure. This properly
reports the test as an error and the exception provides more information
about what is failing so that hopefully we can fix the root problem.
[ in subversion/bindings/javahl/ ]
* tests/org/tigris/subversion/javahl/BasicTests.java
(getMergeinfoRevisions): Throw SubversionException rather than catching it.
Modified:
subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/BasicTests.java
Modified:
subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/BasicTests.java
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/BasicTests.java?rev=891758&r1=891757&r2=891758&view=diff
==============================================================================
---
subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/BasicTests.java
(original)
+++
subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/BasicTests.java
Thu Dec 17 15:21:45 2009
@@ -2247,7 +2247,9 @@
private long[] getMergeinfoRevisions(int kind, String pathOrUrl,
Revision pegRevision,
String mergeSourceUrl,
- Revision srcPegRevision) {
+ Revision srcPegRevision)
+ throws SubversionException
+ {
class Callback implements LogMessageCallback {
List revList = new ArrayList();
@@ -2268,15 +2270,10 @@
return revisions;
}
}
- try {
- Callback callback = new Callback();
- client.getMergeinfoLog(kind, pathOrUrl, pegRevision,
mergeSourceUrl,
- srcPegRevision, false, null, callback);
- return callback.getRevisions();
- } catch (ClientException e) {
- return null;
- }
-
+ Callback callback = new Callback();
+ client.getMergeinfoLog(kind, pathOrUrl, pegRevision, mergeSourceUrl,
+ srcPegRevision, false, null, callback);
+ return callback.getRevisions();
}
/**
