This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new c577191  fix: When click on "View all" from favorite tab, get error 
(#16988)
c577191 is described below

commit c57719128f5208d83ad15268b3d2bb4d00b62954
Author: Michael S. Molina <[email protected]>
AuthorDate: Wed Oct 6 08:18:56 2021 -0300

    fix: When click on "View all" from favorite tab, get error (#16988)
---
 superset-frontend/src/views/CRUD/welcome/ChartTable.tsx     | 2 +-
 superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/views/CRUD/welcome/ChartTable.tsx 
b/superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
index b7d81b3..60a9181 100644
--- a/superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
+++ b/superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
@@ -218,7 +218,7 @@ function ChartTable({
             onClick: () => {
               const target =
                 chartFilter === 'Favorite'
-                  ? '/chart/list/?filters=(favorite:!t)'
+                  ? '/chart/list/?filters=(favorite:(label:Yes,value:!t))'
                   : '/chart/list/';
               history.push(target);
             },
diff --git a/superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx 
b/superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
index 4f8c1ff..0dd594d 100644
--- a/superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
+++ b/superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
@@ -220,7 +220,7 @@ function DashboardTable({
             onClick: () => {
               const target =
                 dashboardFilter === 'Favorite'
-                  ? '/dashboard/list/?filters=(favorite:!t)'
+                  ? '/dashboard/list/?filters=(favorite:(label:Yes,value:!t))'
                   : '/dashboard/list/';
               history.push(target);
             },

Reply via email to