This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 191033c chore: Translates the favorite filter param (#16990)
191033c is described below
commit 191033cb4496876ce594f2b758c1c3f14dfada68
Author: Michael S. Molina <[email protected]>
AuthorDate: Wed Oct 6 11:04:14 2021 -0300
chore: Translates the favorite filter param (#16990)
---
superset-frontend/src/views/CRUD/welcome/ChartTable.tsx | 4 +++-
superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
b/superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
index 60a9181..c673d2a 100644
--- a/superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
+++ b/superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
@@ -218,7 +218,9 @@ function ChartTable({
onClick: () => {
const target =
chartFilter === 'Favorite'
- ? '/chart/list/?filters=(favorite:(label:Yes,value:!t))'
+ ? `/chart/list/?filters=(favorite:(label:${t(
+ 'Yes',
+ )},value:!t))`
: '/chart/list/';
history.push(target);
},
diff --git a/superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
b/superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
index 0dd594d..f4a3d9d 100644
--- a/superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
+++ b/superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
@@ -220,7 +220,9 @@ function DashboardTable({
onClick: () => {
const target =
dashboardFilter === 'Favorite'
- ? '/dashboard/list/?filters=(favorite:(label:Yes,value:!t))'
+ ? `/dashboard/list/?filters=(favorite:(label:${t(
+ 'Yes',
+ )},value:!t))`
: '/dashboard/list/';
history.push(target);
},
