(superset) branch table-time-comparison updated: Table with Time Comparison:

[arivero]

This is an automated email from the ASF dual-hosted git repository.

arivero pushed a commit to branch table-time-comparison
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/table-time-comparison by this 
push:
     new ccbe0c4943 Table with Time Comparison:
ccbe0c4943 is described below

commit ccbe0c4943e460b8b73f4f9df49848d783456165
Author: Antonio Rivero <antonioriveroc...@gmail.com>
AuthorDate: Tue Apr 16 23:57:59 2024 +0200

    Table with Time Comparison:
    
    - Use label and not the sqlExpression when getting the columns for the JOIN
---
 superset/connectors/sqla/models.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset/connectors/sqla/models.py 
b/superset/connectors/sqla/models.py
index ba0a9d3555..73a0667d0c 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -1495,8 +1495,8 @@ class SqlaTable(
         columns_set = set()
         if query_obj_clone.get("columns"):
             for col in query_obj_clone["columns"]:
-                if isinstance(col, dict) and "sqlExpression" in col:
-                    columns_set.add(col["sqlExpression"])
+                if isinstance(col, dict) and "label" in col:
+                    columns_set.add(col["label"])
                 elif isinstance(col, str):
                     columns_set.add(col)
         join_columns = columns_set