(superset) branch table-time-comparison updated: Table with Time Comparison:

[arivero]

This is an automated email from the ASF dual-hosted git repository.

arivero pushed a commit to branch table-time-comparison
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/table-time-comparison by this 
push:
     new 09e84bbfa6 Table with Time Comparison:
09e84bbfa6 is described below

commit 09e84bbfa6ccc8f73745e1efa6ac80dba3fa17f6
Author: Antonio Rivero <antonioriveroc...@gmail.com>
AuthorDate: Wed Apr 17 01:03:28 2024 +0200

    Table with Time Comparison:
    
    - Comparison Label only displays when in Agg mode and when Enable Time 
Comparison is checked
---
 superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx 
b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
index c61b2d6b4b..c36310d48a 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -408,7 +408,12 @@ const config: ControlPanelConfig = {
         [
           {
             name: 'comparison_range_label',
-            config: { type: 'ComparisonRangeLabel' },
+            config: {
+              type: 'ComparisonRangeLabel',
+              visibility: ({ controls }) =>
+                Boolean(controls?.enable_time_comparison?.value) &&
+                isAggMode({ controls }),
+            },
           },
         ],
         [