This is an automated email from the ASF dual-hosted git repository. arivero pushed a commit to branch table-time-comparison-offset in repository https://gitbox.apache.org/repos/asf/superset.git
commit 13319f0f542f2b7c99b67c94d082236b0ff3de2e Author: Lily Kuang <[email protected]> AuthorDate: Tue Apr 9 09:58:29 2024 -0700 fix: table with time comparison shows blank data when dimension is numeric (#27909) - cherry picked from dc5828ede4557f612a85ae09aa8aeee23dd8558a --- superset-frontend/plugins/plugin-chart-table/src/transformProps.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts index a9ead497c3..8e832b05bb 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts @@ -303,7 +303,11 @@ const processComparisonColumns = ( const config = columnConfig[col.key] || {}; const savedFormat = columnFormats?.[col.key]; const numberFormat = config.d3NumberFormat || savedFormat; - if (col.isNumeric && !col.key.includes(comparisonSuffix)) { + if ( + (col.isMetric || col.isPercentMetric) && + !col.key.includes(comparisonSuffix) && + col.isNumeric + ) { return [ { ...col,
