This is an automated email from the ASF dual-hosted git repository. arivero pushed a commit to branch table-time-comparison-offset in repository https://gitbox.apache.org/repos/asf/superset.git
commit 4a5de3a6ab3bd4b01641e20a1d75913997c4fc77 Author: Antonio Rivero <[email protected]> AuthorDate: Mon Apr 15 18:38:56 2024 +0200 Table with Time Comparison: - Align text of comparison metrics to the left --- superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx | 9 ++++----- .../plugins/plugin-chart-table/src/transformProps.ts | 1 + superset-frontend/plugins/plugin-chart-table/src/types.ts | 1 + 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx index 68bacc0aac..50cd9e3c59 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx +++ b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx @@ -242,6 +242,7 @@ export default function TableChart<D extends DataRecord = DataRecord>( allowRenderHtml = true, onContextMenu, emitCrossFilters, + isUsingTimeComparison, } = props; const timestampFormatter = useCallback( value => getTimeFormatterForGranularity(timeGrain)(value), @@ -363,11 +364,9 @@ export default function TableChart<D extends DataRecord = DataRecord>( const getSharedStyle = (column: DataColumnMeta): CSSProperties => { const { isNumeric, config = {} } = column; - const textAlign = config.horizontalAlign - ? config.horizontalAlign - : isNumeric - ? 'right' - : 'left'; + const textAlign = + config.horizontalAlign || + (isNumeric && !isUsingTimeComparison ? 'right' : 'left'); return { textAlign, }; diff --git a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts index 2ae59b9fd6..cf70bfed16 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts @@ -468,6 +468,7 @@ const transformProps = ( allowRearrangeColumns, allowRenderHtml, onContextMenu, + isUsingTimeComparison, }; }; diff --git a/superset-frontend/plugins/plugin-chart-table/src/types.ts b/superset-frontend/plugins/plugin-chart-table/src/types.ts index 639b525d4f..2abba6815d 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/types.ts +++ b/superset-frontend/plugins/plugin-chart-table/src/types.ts @@ -136,6 +136,7 @@ export interface TableChartTransformedProps<D extends DataRecord = DataRecord> { clientY: number, filters?: ContextMenuFilters, ) => void; + isUsingTimeComparison?: boolean; } export default {};
