This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch template_less in repository https://gitbox.apache.org/repos/asf/superset.git
commit 8ce144983d17209112b4c744a06df08ad0a7c940 Author: Maxime Beauchemin <[email protected]> AuthorDate: Mon Mar 24 10:44:07 2025 -0700 fix CopyOutlined icon in dataset view to align with sizing --- .gitattributes | 1 + superset-frontend/src/components/Icons/BaseIcon.tsx | 2 +- superset-frontend/src/components/InfoTooltip/index.tsx | 5 ++--- superset-frontend/src/pages/DatasetList/index.tsx | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.gitattributes b/.gitattributes index 5e7ce3d727..a1918ad4c2 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,3 +1,4 @@ docker/**/*.sh text eol=lf *.svg binary *.ipynb binary +*.geojson binary diff --git a/superset-frontend/src/components/Icons/BaseIcon.tsx b/superset-frontend/src/components/Icons/BaseIcon.tsx index 75f4c87527..b16034a47e 100644 --- a/superset-frontend/src/components/Icons/BaseIcon.tsx +++ b/superset-frontend/src/components/Icons/BaseIcon.tsx @@ -47,7 +47,7 @@ export const BaseIconComponent: React.FC< }) => { const theme = useTheme(); const iconCss = css` - color: ${iconColor || theme.colors.grayscale.base}; + color: ${iconColor || theme.colorIcon}; font-size: ${iconSize ? `${themeObject.getFontSize(iconSize) || theme.fontSize}px` : '24px'}; diff --git a/superset-frontend/src/components/InfoTooltip/index.tsx b/superset-frontend/src/components/InfoTooltip/index.tsx index cb0e2ffda7..f7d4378b0d 100644 --- a/superset-frontend/src/components/InfoTooltip/index.tsx +++ b/superset-frontend/src/components/InfoTooltip/index.tsx @@ -70,7 +70,6 @@ const InfoIconContainer = styled.div` margin-left: ${theme.sizeUnit}px; `} `; -const defaultColor = 'rgba(0,0,0,0.9)'; export default function InfoTooltip({ tooltip, @@ -78,13 +77,13 @@ export default function InfoTooltip({ placement = 'right', trigger = 'hover', overlayStyle = defaultOverlayStyle, - bgColor = defaultColor, + bgColor, viewBox = '0 -1 24 24', }: InfoTooltipProps) { const theme = useTheme(); const alteredIconStyle = { ...iconStyle, - color: iconStyle.color || theme.colors.grayscale.base, + color: iconStyle.color || theme.colorIcon, }; return ( <StyledTooltip diff --git a/superset-frontend/src/pages/DatasetList/index.tsx b/superset-frontend/src/pages/DatasetList/index.tsx index eb8af9f133..69b7880600 100644 --- a/superset-frontend/src/pages/DatasetList/index.tsx +++ b/superset-frontend/src/pages/DatasetList/index.tsx @@ -480,7 +480,7 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({ className="action-button" onClick={handleDuplicate} > - <Icons.CopyOutlined /> + <Icons.CopyOutlined iconSize="l" /> </span> </Tooltip> )}
