This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch template_less in repository https://gitbox.apache.org/repos/asf/superset.git
commit 56e3d165dd69c8a4a6da3bfbb11e0f73cd3d964f Author: Maxime Beauchemin <[email protected]> AuthorDate: Mon Mar 24 12:54:01 2025 -0700 theme toast icons and various cosmetic updates --- .../SqlLab/components/ShareSqlLabQuery/index.tsx | 1 + .../src/components/MessageToasts/Toast.tsx | 30 ++++++++++++++++++---- superset-frontend/src/features/home/Menu.tsx | 3 +-- 3 files changed, 27 insertions(+), 7 deletions(-) diff --git a/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx b/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx index d415efa0fe..7f0402868b 100644 --- a/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx +++ b/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx @@ -75,6 +75,7 @@ const ShareSqlLabQuery = ({ return ( <Button buttonSize="small" + buttonStyle="secondary" tooltip={tooltip} css={css` span > :first-of-type { diff --git a/superset-frontend/src/components/MessageToasts/Toast.tsx b/superset-frontend/src/components/MessageToasts/Toast.tsx index c59c1aac20..d8bc73964e 100644 --- a/superset-frontend/src/components/MessageToasts/Toast.tsx +++ b/superset-frontend/src/components/MessageToasts/Toast.tsx @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -import { styled, css, SupersetTheme } from '@superset-ui/core'; +import { styled, css, SupersetTheme, useTheme } from '@superset-ui/core'; import cx from 'classnames'; import { Interweave } from 'interweave'; import { useCallback, useEffect, useRef, useState } from 'react'; @@ -84,19 +84,39 @@ export default function Toast({ toast, onCloseToast }: ToastPresenterProps) { }; }, [handleClosePress, toast.duration]); + const theme = useTheme(); + let className = 'toast--success'; let icon = ( - <Icons.CheckCircleFilled css={theme => notificationStyledIcon(theme)} /> + <Icons.CheckCircleFilled + css={theme => notificationStyledIcon(theme)} + iconColor={theme.colorSuccess} + /> ); if (toast.toastType === ToastType.Warning) { - icon = <Icons.ExclamationCircleFilled css={notificationStyledIcon} />; + icon = ( + <Icons.ExclamationCircleFilled + css={notificationStyledIcon} + iconColor={theme.colorWarning} + /> + ); className = 'toast--warning'; } else if (toast.toastType === ToastType.Danger) { - icon = <Icons.ExclamationCircleFilled css={notificationStyledIcon} />; + icon = ( + <Icons.ExclamationCircleFilled + css={notificationStyledIcon} + iconColor={theme.colorError} + /> + ); className = 'toast--danger'; } else if (toast.toastType === ToastType.Info) { - icon = <Icons.InfoCircleFilled css={notificationStyledIcon} />; + icon = ( + <Icons.InfoCircleFilled + css={notificationStyledIcon} + iconColor={theme.colorInfo} + /> + ); className = 'toast--info'; } diff --git a/superset-frontend/src/features/home/Menu.tsx b/superset-frontend/src/features/home/Menu.tsx index 9ca44863d2..9ffe856dbe 100644 --- a/superset-frontend/src/features/home/Menu.tsx +++ b/superset-frontend/src/features/home/Menu.tsx @@ -42,8 +42,7 @@ interface MenuProps { const StyledHeader = styled.header` ${({ theme }) => ` - background-color: ${theme.colorBgElevated}; - margin-bottom: 2px; + background-color: ${theme.colorBgContainer}; z-index: 10; &:nth-last-of-type(2) nav {
