This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch 5.0
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 34b4edb372e52c44daa9300f2d44734559d4b591
Author: Vitor Avila <[email protected]>
AuthorDate: Wed Mar 26 13:28:22 2025 -0300

    fix(table-chart): Do not show comparison columns config if time_compare is 
set to [] (#32863)
    
    (cherry picked from commit f0dc1e7527b3d13888c7bb4833da56c12c6aaa3c)
---
 superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx 
b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
index 933ee6a0c1..ef3a8e700c 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -486,8 +486,9 @@ const config: ControlPanelConfig = {
                 return true;
               },
               mapStateToProps(explore, _, chart) {
-                const timeComparisonStatus =
-                  !!explore?.controls?.time_compare?.value;
+                const timeComparisonStatus = !isEmpty(
+                  explore?.controls?.time_compare?.value,
+                );
 
                 const { colnames: _colnames, coltypes: _coltypes } =
                   chart?.queriesResponse?.[0] ?? {};

Reply via email to