This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch various_ux in repository https://gitbox.apache.org/repos/asf/superset.git
commit aa392d46d3b7b9e0aad34566086a7fba7c6e5ca4 Author: Maxime Beauchemin <[email protected]> AuthorDate: Mon May 5 16:56:43 2025 -0700 make control panel errors show as alert + CloseCircleOutlined --- .../src/explore/components/ControlHeader.tsx | 9 ++------- .../src/explore/components/ControlPanelsContainer.tsx | 15 ++++----------- 2 files changed, 6 insertions(+), 18 deletions(-) diff --git a/superset-frontend/src/explore/components/ControlHeader.tsx b/superset-frontend/src/explore/components/ControlHeader.tsx index 3a11504ee5..8d44910f2c 100644 --- a/superset-frontend/src/explore/components/ControlHeader.tsx +++ b/superset-frontend/src/explore/components/ControlHeader.tsx @@ -163,7 +163,7 @@ const ControlHeader: FC<ControlHeaderProps> = ({ {danger && ( <span> <Tooltip id="error-tooltip" placement="top" title={danger}> - <Icons.ExclamationCircleOutlined + <Icons.CloseCircleOutlined iconColor={theme.colorErrorText} iconSize="s" /> @@ -177,12 +177,7 @@ const ControlHeader: FC<ControlHeaderProps> = ({ placement="top" title={validationErrors?.join(' ')} > - <Icons.ExclamationCircleOutlined - css={css` - ${iconStyles}; - color: ${labelColor}; - `} - /> + <Icons.CloseCircleOutlined iconColor={theme.colorErrorText} /> </Tooltip>{' '} </span> )} diff --git a/superset-frontend/src/explore/components/ControlPanelsContainer.tsx b/superset-frontend/src/explore/components/ControlPanelsContainer.tsx index 182049fbbc..de75108851 100644 --- a/superset-frontend/src/explore/components/ControlPanelsContainer.tsx +++ b/superset-frontend/src/explore/components/ControlPanelsContainer.tsx @@ -581,12 +581,7 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => { id={`${kebabCase('validation-errors')}-tooltip`} title={t('This section contains validation errors')} > - <Icons.InfoCircleOutlined - css={css` - ${iconStyles}; - color: ${errorColor}; - `} - /> + <Icons.CloseCircleOutlined iconColor={theme.colorErrorText} /> </Tooltip> )} </span> @@ -715,11 +710,9 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => { placement="right" title={props.errorMessage} > - <Icons.ExclamationCircleOutlined - css={css` - ${iconStyles}; - color: ${errorColor}; - `} + <Icons.CloseCircleOutlined + iconColor={theme.colorErrorText} + iconSize="s" /> </Tooltip> </span>
