This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch various_ux in repository https://gitbox.apache.org/repos/asf/superset.git
commit ef616048fa52faed2ac8c7d38c5966e5d10468b1 Author: Maxime Beauchemin <[email protected]> AuthorDate: Mon May 5 16:35:36 2025 -0700 fix: various theme/ui CSS issues --- superset-frontend/package-lock.json | 2 +- .../src/explore/components/controls/OptionControls/index.tsx | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json index ccb4d0f117..08682f0b90 100644 --- a/superset-frontend/package-lock.json +++ b/superset-frontend/package-lock.json @@ -53944,7 +53944,7 @@ "@storybook/react-webpack5": "8.2.9", "babel-loader": "^9.1.3", "fork-ts-checker-webpack-plugin": "^9.0.2", - "ts-loader": "^9.5.1", + "ts-loader": "^9.5.2", "typescript": "^5.7.2" }, "peerDependencies": { diff --git a/superset-frontend/src/explore/components/controls/OptionControls/index.tsx b/superset-frontend/src/explore/components/controls/OptionControls/index.tsx index 037ce6ece2..67acc4957c 100644 --- a/superset-frontend/src/explore/components/controls/OptionControls/index.tsx +++ b/superset-frontend/src/explore/components/controls/OptionControls/index.tsx @@ -133,7 +133,7 @@ export const DndLabelsContainer = styled.div<{ padding: ${theme.sizeUnit}px; border: ${ !isLoading && isDragging - ? `dashed 1px ${canDrop ? theme.colorBorder : theme.colorErrorBgHover}` + ? `dashed 1px ${canDrop ? theme.colorSplit : theme.colorErrorBgHover}` : `solid 1px ${ isLoading && isDragging ? theme.colorWarningBgHover @@ -198,7 +198,7 @@ export const AddControlLabel = styled.div<{ padding-left: ${({ theme }) => theme.sizeUnit}px; font-size: ${({ theme }) => theme.fontSizeSM}px; color: ${({ theme }) => theme.colors.grayscale.light1}; - border: dashed 1px ${({ theme }) => theme.colors.grayscale.light2}; + border: dashed 1px ${({ theme }) => theme.colorSplit}; border-radius: ${({ theme }) => theme.sizeUnit}px; cursor: ${({ cancelHover }) => (cancelHover ? 'inherit' : 'pointer')}; @@ -211,6 +211,9 @@ export const AddControlLabel = styled.div<{ background-color: ${({ cancelHover, theme }) => cancelHover ? 'inherit' : theme.colors.grayscale.light3}; } + svg { + margin-right: ${({ theme }) => theme.sizeUnit}px; + } `; export const AddIconButton = styled.button`
