This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 1190ebb [datasource] Ensure SQL Lab link opens in a new tab (#6195)
1190ebb is described below
commit 1190ebb1a8bf704c6397a7ea5ac66226bfa69566
Author: John Bodley <[email protected]>
AuthorDate: Tue Oct 30 17:06:27 2018 -0700
[datasource] Ensure SQL Lab link opens in a new tab (#6195)
---
.../assets/src/explore/components/controls/DatasourceControl.jsx | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/superset/assets/src/explore/components/controls/DatasourceControl.jsx
b/superset/assets/src/explore/components/controls/DatasourceControl.jsx
index 271eda9..03d1fbb 100644
--- a/superset/assets/src/explore/components/controls/DatasourceControl.jsx
+++ b/superset/assets/src/explore/components/controls/DatasourceControl.jsx
@@ -127,11 +127,15 @@ class DatasourceControl extends React.PureComponent {
placement="right"
overlay={
<Tooltip id={'datasource-sqllab'}>
- {t('Run SQL queries against this datasource')}
+ {t('Explore this datasource in SQL Lab')}
</Tooltip>
}
>
- <a href={'/superset/sqllab?datasourceKey=' + this.props.value}>
+ <a
+ href={`/superset/sqllab?datasourceKey=${this.props.value}`}
+ target="_blank"
+ rel="noopener noreferrer"
+ >
<i className="fa fa-flask m-r-5" />
</a>
</OverlayTrigger>}
