[incubator-superset] branch master updated: [sql lab] improve placeholder strings for query search form (#6228)

[maximebeauchemin]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 2ad8e2e  [sql lab] improve placeholder strings for query search form 
(#6228)
2ad8e2e is described below

commit 2ad8e2ee2bf7cd72e075418d843884813980606a
Author: Maxime Beauchemin <maximebeauche...@gmail.com>
AuthorDate: Tue Oct 30 21:29:43 2018 -0700

    [sql lab] improve placeholder strings for query search form (#6228)
---
 superset/assets/src/SqlLab/components/QuerySearch.jsx | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/superset/assets/src/SqlLab/components/QuerySearch.jsx 
b/superset/assets/src/SqlLab/components/QuerySearch.jsx
index 62d0255..06c9e25 100644
--- a/superset/assets/src/SqlLab/components/QuerySearch.jsx
+++ b/superset/assets/src/SqlLab/components/QuerySearch.jsx
@@ -183,6 +183,7 @@ class QuerySearch extends React.PureComponent {
               mutator={this.userMutator}
               value={this.state.userId}
               onChange={this.changeUser}
+              placeholder={t('Filter by user')}
             />
           </div>
           <div className="col-sm-2">
@@ -191,6 +192,7 @@ class QuerySearch extends React.PureComponent {
               dataEndpoint="/databaseasync/api/read?_flt_0_expose_in_sqllab=1"
               value={this.state.databaseId}
               mutator={this.dbMutator}
+              placeholder={t('Filter by database')}
             />
           </div>
           <div className="col-sm-4">
@@ -199,7 +201,7 @@ class QuerySearch extends React.PureComponent {
               onChange={this.changeSearch}
               onKeyDown={this.onKeyDown}
               className="form-control input-sm"
-              placeholder={t('Search Results')}
+              placeholder={t('Query search string')}
             />
           </div>
           <div className="col-sm-4 search-date-filter-container">
@@ -226,7 +228,7 @@ class QuerySearch extends React.PureComponent {
 
             <Select
               name="select-status"
-              placeholder={t('[Query Status]')}
+              placeholder={t('Filter by status')}
               options={Object.keys(STATUS_OPTIONS).map(s => ({ value: s, 
label: s }))}
               value={this.state.status}
               isLoading={false}