[incubator-superset] 08/13: fix favstar user-login condition

[beto]

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch fix_ro_tags
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit d1eb07c915557b17eeecbb807092568b719196f1
Author: Dave Smith <davesm...@lyft.com>
AuthorDate: Mon Feb 17 10:53:09 2020 -0800

    fix favstar user-login condition
---
 superset-frontend/src/dashboard/components/Header.jsx | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/superset-frontend/src/dashboard/components/Header.jsx 
b/superset-frontend/src/dashboard/components/Header.jsx
index 4335dcc..0ddde06 100644
--- a/superset-frontend/src/dashboard/components/Header.jsx
+++ b/superset-frontend/src/dashboard/components/Header.jsx
@@ -352,14 +352,16 @@ class Header extends React.PureComponent {
               canSave={userCanSaveAs}
             />
           </span>
-          <span className="favstar">
-            <FaveStar
-              itemId={dashboardInfo.id}
-              fetchFaveStar={this.props.fetchFaveStar}
-              saveFaveStar={this.props.saveFaveStar}
-              isStarred={this.props.isStarred}
-            />
-          </span>
+          {dashboardInfo.userId && (
+            <span className="favstar">
+              <FaveStar
+                itemId={dashboardInfo.id}
+                fetchFaveStar={this.props.fetchFaveStar}
+                saveFaveStar={this.props.saveFaveStar}
+                isStarred={this.props.isStarred}
+              />
+            </span>
+          )}
           <ObjectTags
             fetchTags={this.fetchTags}
             fetchSuggestions={this.fetchSuggestions}