This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch fix_ro_tags
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 0bab5e78487e591f3deea3287619656b69602b5a
Author: Dave Smith <davesm...@lyft.com>
AuthorDate: Wed Jan 22 14:44:06 2020 -0800

    fix props undefined test failure
---
 superset/assets/src/components/ObjectTags.jsx | 2 +-
 superset/assets/src/welcome/Welcome.jsx       | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/superset/assets/src/components/ObjectTags.jsx 
b/superset/assets/src/components/ObjectTags.jsx
index 910d99c..68744d8 100644
--- a/superset/assets/src/components/ObjectTags.jsx
+++ b/superset/assets/src/components/ObjectTags.jsx
@@ -124,7 +124,7 @@ export default class ObjectTags extends React.Component {
         {this.state.tags.map(tag => (
           <Label bsStyle="info">
             <a
-              
href={`/superset/welcome?filters=%5B%5D&pageIndex=0&search=${props.tag.name}&sortColumn=changed_on&sortOrder=desc`}
+              
href={`/superset/welcome?filters=%5B%5D&pageIndex=0&search=${this.props.tag.name}&sortColumn=changed_on&sortOrder=desc`}
               className="deco-none"
             >
               {tag.name}
diff --git a/superset/assets/src/welcome/Welcome.jsx 
b/superset/assets/src/welcome/Welcome.jsx
index dca30a0..aec06cb 100644
--- a/superset/assets/src/welcome/Welcome.jsx
+++ b/superset/assets/src/welcome/Welcome.jsx
@@ -20,7 +20,6 @@ import React, { useEffect, useState } from 'react';
 import PropTypes from 'prop-types';
 import { Panel, Row, Col, Tabs, Tab, FormControl } from 'react-bootstrap';
 import { t } from '@superset-ui/translation';
-import URI from 'urijs';
 import { useQueryParam, StringParam } from 'use-query-params';
 import RecentActivity from '../profile/components/RecentActivity';
 import Favorites from '../profile/components/Favorites';

Reply via email to