Repository: tajo Updated Branches: refs/heads/master 394879e0f -> b677b988f
TAJO-2019: Replace manual array copy with System.arraycopy(). Closes #909 Signed-off-by: Jihoon Son <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/tajo/repo Commit: http://git-wip-us.apache.org/repos/asf/tajo/commit/b677b988 Tree: http://git-wip-us.apache.org/repos/asf/tajo/tree/b677b988 Diff: http://git-wip-us.apache.org/repos/asf/tajo/diff/b677b988 Branch: refs/heads/master Commit: b677b988fd6ddda3516f4f9f3298dd7bf8f5d99d Parents: 394879e Author: Dongkyu Hwangbo <[email protected]> Authored: Mon Dec 14 12:37:15 2015 +0900 Committer: Jihoon Son <[email protected]> Committed: Mon Dec 14 12:37:15 2015 +0900 ---------------------------------------------------------------------- CHANGES | 4 +++- .../src/main/java/org/apache/tajo/util/StringUtils.java | 8 ++------ .../org/apache/tajo/plan/logical/DistinctGroupbyNode.java | 4 +--- .../main/java/org/apache/tajo/plan/logical/GroupbyNode.java | 4 +--- .../java/org/apache/tajo/plan/logical/WindowAggNode.java | 4 +--- 5 files changed, 8 insertions(+), 16 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tajo/blob/b677b988/CHANGES ---------------------------------------------------------------------- diff --git a/CHANGES b/CHANGES index 25a4791..d6c6267 100644 --- a/CHANGES +++ b/CHANGES @@ -119,10 +119,12 @@ Release 0.12.0 - unreleased TASKS + TAJO-2019: Replace manual array copy with System.arraycopy(). (jihoon) + TAJO-1994: Some trivial modification is needed in compression document. (Contributed by Jongyoung Park. Committed by jihoon) - TAJO-1973: Replace 'while' loop with 'foreach'. (Contributed by Dongkyu Hwangbo, i + TAJO-1973: Replace 'while' loop with 'foreach'. (Contributed by Dongkyu Hwangbo, committed by jihoon) TAJO-1855: Add document for tablespace configuration to the Configuration chapter. http://git-wip-us.apache.org/repos/asf/tajo/blob/b677b988/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java ---------------------------------------------------------------------- diff --git a/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java b/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java index 1cb25ca..b03634d 100644 --- a/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java +++ b/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java @@ -310,15 +310,11 @@ public class StringUtils { padded[0] = new char[max]; padded[1] = new char[max]; - for (int i = 0; i < startChars.length; i++) { - padded[0][i] = startChars[i]; - } + System.arraycopy(startChars, 0, padded[0], 0, startChars.length); for (int i = startChars.length; i < max; i++) { padded[0][i] = 0; } - for (int i = 0; i < endChars.length; i++) { - padded[1][i] = endChars[i]; - } + System.arraycopy(endChars, 0, padded[1], 0, endChars.length); for (int i = endChars.length; i < max; i++) { padded[1][i] = 0; } http://git-wip-us.apache.org/repos/asf/tajo/blob/b677b988/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java ---------------------------------------------------------------------- diff --git a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java index 399c1b8..8bafccf 100644 --- a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java +++ b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java @@ -117,9 +117,7 @@ public class DistinctGroupbyNode extends UnaryNode implements Projectable, Clone if (groupingColumns != null) { cloneNode.groupingColumns = new Column[groupingColumns.length]; - for (int i = 0; i < groupingColumns.length; i++) { - cloneNode.groupingColumns[i] = groupingColumns[i]; - } + System.arraycopy(groupingColumns, 0, cloneNode.groupingColumns, 0, groupingColumns.length); } if (subGroupbyPlan != null) { http://git-wip-us.apache.org/repos/asf/tajo/blob/b677b988/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java ---------------------------------------------------------------------- diff --git a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java index 3d487b8..fc82afc 100644 --- a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java +++ b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java @@ -166,9 +166,7 @@ public class GroupbyNode extends UnaryNode implements Projectable, Cloneable { GroupbyNode grp = (GroupbyNode) super.clone(); if (groupingKeys != null) { grp.groupingKeys = new Column[groupingKeys.length]; - for (int i = 0; i < groupingKeys.length; i++) { - grp.groupingKeys[i] = groupingKeys[i]; - } + System.arraycopy(groupingKeys, 0, grp.groupingKeys, 0, groupingKeys.length); } if (aggrFunctions != null) { http://git-wip-us.apache.org/repos/asf/tajo/blob/b677b988/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java ---------------------------------------------------------------------- diff --git a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java index b0b8788..9e58ba3 100644 --- a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java +++ b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java @@ -157,9 +157,7 @@ public class WindowAggNode extends UnaryNode implements Projectable, Cloneable { WindowAggNode grp = (WindowAggNode) super.clone(); if (partitionKeys != null) { grp.partitionKeys = new Column[partitionKeys.length]; - for (int i = 0; i < partitionKeys.length; i++) { - grp.partitionKeys[i] = partitionKeys[i]; - } + System.arraycopy(partitionKeys, 0, grp.partitionKeys, 0, partitionKeys.length); } if (windowFuncs != null) {
