Repository: tajo Updated Branches: refs/heads/branch-0.11.1 0a17877f9 -> 040636d03
TAJO-2019: Replace manual array copy with System.arraycopy(). Signed-off-by: Jihoon Son <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/tajo/repo Commit: http://git-wip-us.apache.org/repos/asf/tajo/commit/040636d0 Tree: http://git-wip-us.apache.org/repos/asf/tajo/tree/040636d0 Diff: http://git-wip-us.apache.org/repos/asf/tajo/diff/040636d0 Branch: refs/heads/branch-0.11.1 Commit: 040636d03e96d2ef02f8b43d3a8721cb9c2c40cb Parents: 0a17877 Author: Dongkyu Hwangbo <[email protected]> Authored: Mon Dec 14 12:42:57 2015 +0900 Committer: Jihoon Son <[email protected]> Committed: Mon Dec 14 12:42:57 2015 +0900 ---------------------------------------------------------------------- CHANGES | 3 +++ .../src/main/java/org/apache/tajo/util/StringUtils.java | 8 ++------ .../org/apache/tajo/plan/logical/DistinctGroupbyNode.java | 4 +--- .../main/java/org/apache/tajo/plan/logical/GroupbyNode.java | 4 +--- .../java/org/apache/tajo/plan/logical/WindowAggNode.java | 4 +--- 5 files changed, 8 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tajo/blob/040636d0/CHANGES ---------------------------------------------------------------------- diff --git a/CHANGES b/CHANGES index feb723e..8756d5e 100644 --- a/CHANGES +++ b/CHANGES @@ -71,6 +71,9 @@ Release 0.11.1 - unreleased TASKS + TAJO-2019: Replace manual array copy with System.arraycopy(). + (Contributed by Dongkyu Hwangbo, committed by jaehwa) + TAJO-1994: Some trivial modification is needed in compression document. (Contributed by Jongyoung Park. Committed by jihoon) http://git-wip-us.apache.org/repos/asf/tajo/blob/040636d0/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java ---------------------------------------------------------------------- diff --git a/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java b/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java index 2d57c0a..587849f 100644 --- a/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java +++ b/tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java @@ -308,15 +308,11 @@ public class StringUtils { padded[0] = new char[max]; padded[1] = new char[max]; - for (int i = 0; i < startChars.length; i++) { - padded[0][i] = startChars[i]; - } + System.arraycopy(startChars, 0, padded[0], 0, startChars.length); for (int i = startChars.length; i < max; i++) { padded[0][i] = 0; } - for (int i = 0; i < endChars.length; i++) { - padded[1][i] = endChars[i]; - } + System.arraycopy(endChars, 0, padded[1], 0, endChars.length); for (int i = endChars.length; i < max; i++) { padded[1][i] = 0; } http://git-wip-us.apache.org/repos/asf/tajo/blob/040636d0/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java ---------------------------------------------------------------------- diff --git a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java index fb19f10..6c5a24c 100644 --- a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java +++ b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java @@ -116,9 +116,7 @@ public class DistinctGroupbyNode extends UnaryNode implements Projectable, Clone if (groupingColumns != null) { cloneNode.groupingColumns = new Column[groupingColumns.length]; - for (int i = 0; i < groupingColumns.length; i++) { - cloneNode.groupingColumns[i] = groupingColumns[i]; - } + System.arraycopy(groupingColumns, 0, cloneNode.groupingColumns, 0, groupingColumns.length); } if (subGroupbyPlan != null) { http://git-wip-us.apache.org/repos/asf/tajo/blob/040636d0/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java ---------------------------------------------------------------------- diff --git a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java index 3966606..3019437 100644 --- a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java +++ b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java @@ -163,9 +163,7 @@ public class GroupbyNode extends UnaryNode implements Projectable, Cloneable { GroupbyNode grp = (GroupbyNode) super.clone(); if (groupingKeys != null) { grp.groupingKeys = new Column[groupingKeys.length]; - for (int i = 0; i < groupingKeys.length; i++) { - grp.groupingKeys[i] = groupingKeys[i]; - } + System.arraycopy(groupingKeys, 0, grp.groupingKeys, 0, groupingKeys.length); } if (aggrFunctions != null) { http://git-wip-us.apache.org/repos/asf/tajo/blob/040636d0/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java ---------------------------------------------------------------------- diff --git a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java index 1bee34c..1e179fb 100644 --- a/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java +++ b/tajo-plan/src/main/java/org/apache/tajo/plan/logical/WindowAggNode.java @@ -154,9 +154,7 @@ public class WindowAggNode extends UnaryNode implements Projectable, Cloneable { WindowAggNode grp = (WindowAggNode) super.clone(); if (partitionKeys != null) { grp.partitionKeys = new Column[partitionKeys.length]; - for (int i = 0; i < partitionKeys.length; i++) { - grp.partitionKeys[i] = partitionKeys[i]; - } + System.arraycopy(partitionKeys, 0, grp.partitionKeys, 0, partitionKeys.length); } if (windowFuncs != null) {
