[
https://issues.apache.org/jira/browse/TAP5-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carl Crowder updated TAP5-797:
------------------------------
Attachment: check_no_script_tag_if_no_scripts.diff
Added a patch with a fix and an additional unit test to verify.
> Using "tapestry.combine-scripts" with an EmptyClientInfrastructure still adds
> an empty JavaScript file
> ------------------------------------------------------------------------------------------------------
>
> Key: TAP5-797
> URL: https://issues.apache.org/jira/browse/TAP5-797
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Carl Crowder
> Priority: Minor
> Attachments: check_no_script_tag_if_no_scripts.diff
>
>
> If you have "tapestry.combine-scripts" set to true, and override the
> ClientInfrastructure service to not add any assets, the DocumentLinkerImpl
> still inserts a SCRIPT tag into the document. The JavaScript it generates is
> empty except for a call to the Tapestry JavaScript object, which isn't part
> of the page anyway as no other JavaScript has been loaded.
> This a) causes a JavaScript error and b) adds unecessary HTTP requests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
