[ 
https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011002#comment-13011002
 ] 

Howard M. Lewis Ship commented on TAP5-1483:
--------------------------------------------

Just trying to figure out why this is necessary ... whta's your scenario where 
very URL needs to be fully qualified with hostname?  Surely, one would think 
that getting the page request URLs to be fully qualified, with the asset URLs 
relative to those page request URLs, should be sufficient?

> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
>                 Key: TAP5-1483
>                 URL: https://issues.apache.org/jira/browse/TAP5-1483
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.4
>            Reporter: Jonathan Barker
>            Priority: Minor
>         Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just 
> the request context path to match the behavior for pages, etc.  Currently, to 
> get absolute URL's including domain portion for assets, you need to override 
> the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
>         StringBuilder builder = new StringBuilder(request.getContextPath());
> to
>         StringBuilder builder = new 
> StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
>         builder.append(request.getContextPath());
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to