[
https://issues.apache.org/jira/browse/TAP5-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679213#comment-16679213
]
Andrew Fowler commented on TAP5-2588:
-------------------------------------
Intriguing. No problems on my end. I did upgrade Gradle to 4.10.2 in the patch,
but I see the Jenkins build used 4.3.1. I wonder if 4.10.2 could somehow be
giving me a false negative, or 4.3.1 giving you a false positive? Today:
{code:java}
tapestry-5 ±:deeef51 ❯ export JAVA_HOME=$(/usr/libexec/java_home -v 1.8)
tapestry-5 ±:deeef51 ❯ java -version
java version "1.8.0_181"
Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
tapestry-5 ±:deeef51 ❯ ./gradlew -v
------------------------------------------------------------
Gradle 4.10.2
------------------------------------------------------------
Build time: 2018-09-19 18:10:15 UTC
Revision: b4d8d5d170bb4ba516e88d7fe5647e2323d791dd
Kotlin DSL: 1.0-rc-6
Kotlin: 1.2.61
Groovy: 2.4.15
Ant: Apache Ant(TM) version 1.9.11 compiled on March 23 2018
JVM: 1.8.0_181 (Oracle Corporation 25.181-b13)
OS: Mac OS X 10.12.6 x86_64{code}
I did see 2 failures here:
{code:java}
tapestry-5 ±:deeef51 ❯ ./gradlew clean test
........
> Task :tapestry-core:test
Tapestry Core > Core Integration Tests >
org.apache.tapestry5.integration.app1.ZoneTests.update_multiple_zones_at_once
FAILED
java.lang.AssertionError at ZoneTests.java:116
Tapestry Core > Core Integration Tests >
org.apache.tapestry5.integration.app1.ConfirmMixinTests.confirm_mixin FAILED
org.openqa.selenium.TimeoutException at ConfirmMixinTests.groovy:14
1537 tests completed, 2 failed
> Task :tapestry-core:test FAILED{code}
...but they passed fine on a re-run:
{code:java}
tapestry-5 ±:deeef51 ❯ ./gradlew tapestry-core:test --rerun-tasks --tests
org.apache.tapestry5.integration.app1.ZoneTests.* tapestry-core:test
--rerun-tasks --tests org.apache.tapestry5.integration.app1.ConfirmMixinTests.*
........
BUILD SUCCESSFUL in 1m 34s
35 actionable tasks: 35 executed
{code}
{code:java}
tapestry-5 ±:deeef51 ❯ ./gradlew test
........
> Task :tapestry-webresources:test
t5.webresources.tests.WebResourcesSpec > classMethod FAILED
java.net.BindException at WebResourcesSpec.groovy:13
4 tests completed, 1 failed
> Task :tapestry-webresources:test FAILED{code}
Failed here because I had something else listening on :8080. Stopped that
process and continued:
{code:java}
tapestry-5 ±:deeef51 ❯ ./gradlew test
........
BUILD SUCCESSFUL in 39s
116 actionable tasks: 1 executed, 115 up-to-date{code}
For good measure:
{code:java}
tapestry-5 ±:deeef51 ❯ ./gradlew tapestry-beanvalidator:test --rerun-tasks
........
BUILD SUCCESSFUL in 1m 0s
36 actionable tasks: 36 executed{code}
The Selenium tests ran against Firefox 63.0.
> Does not work with Java 9
> -------------------------
>
> Key: TAP5-2588
> URL: https://issues.apache.org/jira/browse/TAP5-2588
> Project: Tapestry 5
> Issue Type: Bug
> Components: plastic
> Affects Versions: 5.4.3
> Reporter: Jochen Kemnade
> Assignee: Bob Harner
> Priority: Critical
> Attachments:
> 0001-TAP5-2588-Upgrade-ASM-6.x-7.0.1-for-Java-11-support.patch
>
>
> You cannot use Tapestry with Java 9 because of an outdated ASM version in
> plastic (5.0.4). AFAICT, we'll need to upgrade to 6.0. My attempt do do so
> results in a {{ClassCastException}} in
> {{org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit values for
> array attributes}}.
> {noformat}
> java.lang.ClassCastException: [I cannot be cast to
> java.base/[Ljava.lang.Object;
> at
> org.apache.tapestry5.internal.plastic.AbstractAnnotationBuilder$2.visitEnd(AbstractAnnotationBuilder.java:134)
> at
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:284)
> at
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:251)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.createAnnotation(PlasticClassPool.java:307)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.buildAnnotation(PlasticClassPool.java:286)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.getAnnotation(PlasticClassPool.java:270)
> at
> org.apache.tapestry5.internal.plastic.DelegatingAnnotationAccess.getAnnotation(DelegatingAnnotationAccess.java:42)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassImpl.getAnnotation(PlasticClassImpl.java:342)
> at org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit
> values for array attributes(ArrayAttributeAnnotations.groovy:27)
> {noformat}
> The {{AbstractAnnotationBuilder}} subclass tries to cast an {{int[]}} to an
> {{Object[]}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
