[
https://issues.apache.org/jira/browse/TAP5-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700303#comment-16700303
]
Thiago H. de Paula Figueiredo commented on TAP5-2588:
-----------------------------------------------------
Hello, [~andrewfowler]!
Thank you for your patch and suggestions!
I just wanted to have the build fixed before applying the patch, so we could be
sure whether it didn't break anything, and the Jenkins build is the best place
to do it. The build is now passing, so I plan to apply the patch today or
tomorrow.
I've also created a separate job,
[http://builds.apache.org/job/tapestry-trunk-freestyle-java-9] , to build the
sources and run the tests under Java 9. It's failing right at the start and I
plan to work on it later this week.
I agree with you that we should probably have Tapestry 5.5 covering Java 8 and
9 and 5.6 covering Java 10 onwards, or maybe even more Java version-specific
Tapestry releases. I don't want to talk about specific plans now, since I
couldn't work with Java 9+ yet, so I'm not sure what challenges we'll be
facing. But I'm sure we'll overcome them. :)
> Does not work with Java 9
> -------------------------
>
> Key: TAP5-2588
> URL: https://issues.apache.org/jira/browse/TAP5-2588
> Project: Tapestry 5
> Issue Type: Bug
> Components: plastic
> Affects Versions: 5.4.3
> Reporter: Jochen Kemnade
> Assignee: Bob Harner
> Priority: Critical
> Attachments:
> 0001-TAP5-2588-Upgrade-ASM-6.x-7.0.1-for-Java-11-support.patch
>
>
> You cannot use Tapestry with Java 9 because of an outdated ASM version in
> plastic (5.0.4). AFAICT, we'll need to upgrade to 6.0. My attempt do do so
> results in a {{ClassCastException}} in
> {{org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit values for
> array attributes}}.
> {noformat}
> java.lang.ClassCastException: [I cannot be cast to
> java.base/[Ljava.lang.Object;
> at
> org.apache.tapestry5.internal.plastic.AbstractAnnotationBuilder$2.visitEnd(AbstractAnnotationBuilder.java:134)
> at
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:284)
> at
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:251)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.createAnnotation(PlasticClassPool.java:307)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.buildAnnotation(PlasticClassPool.java:286)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.getAnnotation(PlasticClassPool.java:270)
> at
> org.apache.tapestry5.internal.plastic.DelegatingAnnotationAccess.getAnnotation(DelegatingAnnotationAccess.java:42)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassImpl.getAnnotation(PlasticClassImpl.java:342)
> at org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit
> values for array attributes(ArrayAttributeAnnotations.groovy:27)
> {noformat}
> The {{AbstractAnnotationBuilder}} subclass tries to cast an {{int[]}} to an
> {{Object[]}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
