remove checkstyle and PMD error
Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/commit/ed7298ff Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/tree/ed7298ff Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/diff/ed7298ff Branch: refs/heads/master Commit: ed7298ffa388069f9cba2eec53e0688ac65af97b Parents: 22d058d Author: Sagar <[email protected]> Authored: Tue Oct 18 19:54:19 2016 +0530 Committer: Sagar <[email protected]> Committed: Tue Oct 18 19:54:19 2016 +0530 ---------------------------------------------------------------------- .../mobile/data/model/licence/LicenceContent.java | 3 --- .../taverna/mobile/ui/licence/LicenceFragment.java | 12 ++++++------ 2 files changed, 6 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/ed7298ff/app/src/main/java/org/apache/taverna/mobile/data/model/licence/LicenceContent.java ---------------------------------------------------------------------- diff --git a/app/src/main/java/org/apache/taverna/mobile/data/model/licence/LicenceContent.java b/app/src/main/java/org/apache/taverna/mobile/data/model/licence/LicenceContent.java index a3e93ba..74b2d42 100644 --- a/app/src/main/java/org/apache/taverna/mobile/data/model/licence/LicenceContent.java +++ b/app/src/main/java/org/apache/taverna/mobile/data/model/licence/LicenceContent.java @@ -1,8 +1,5 @@ package org.apache.taverna.mobile.data.model.licence; -import com.google.gson.annotations.SerializedName; - - public class LicenceContent { private String name; http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/ed7298ff/app/src/main/java/org/apache/taverna/mobile/ui/licence/LicenceFragment.java ---------------------------------------------------------------------- diff --git a/app/src/main/java/org/apache/taverna/mobile/ui/licence/LicenceFragment.java b/app/src/main/java/org/apache/taverna/mobile/ui/licence/LicenceFragment.java index e8cc856..19ac78f 100644 --- a/app/src/main/java/org/apache/taverna/mobile/ui/licence/LicenceFragment.java +++ b/app/src/main/java/org/apache/taverna/mobile/ui/licence/LicenceFragment.java @@ -24,6 +24,7 @@ import android.support.annotation.Nullable; import android.support.v4.app.Fragment; import android.support.v7.widget.LinearLayoutManager; import android.support.v7.widget.RecyclerView; +import android.util.Log; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; @@ -37,7 +38,6 @@ import org.apache.taverna.mobile.ui.adapter.LicenceRecyclerViewAdapter; import java.io.IOException; import java.io.InputStream; -import java.lang.reflect.Type; import java.util.List; /** @@ -46,7 +46,7 @@ import java.util.List; public class LicenceFragment extends Fragment { - //private List<LicenceContent> itemList; + private static final String TAG = LicenceFragment.class.getSimpleName(); private Gson gson; @@ -91,12 +91,12 @@ public class LicenceFragment extends Fragment { is.close(); json = new String(buffer, "UTF-8"); } catch (IOException ex) { - ex.printStackTrace(); + Log.i(TAG, IOException.class.getSimpleName()); return null; } - Type type = new TypeToken<List<LicenceContent>>() { - }.getType(); - itemList = gson.fromJson(json, type); + TypeToken<List<LicenceContent>> typeToken = new TypeToken<List<LicenceContent>>() { + }; + itemList = gson.fromJson(json, typeToken.getType()); return itemList; }
