The GitHub Actions job "Backport Approval Check" on 
texera.git/fix-8315-shared-nonshared-state has failed.
Run started by GitHub user Copilot (triggered by Copilot).

Head commit for run:
1a5d528c2ca2330e797e18f85e8c3bef97894db9 / Yang Zhang <[email protected]>
fix(workflow): hold an edit made before the first sync, and write it after

Review follow-up on #8351, fourth round. An edit of the settings or the form
definition made before the document's first sync went straight into the
document, one more concurrent whole-value write settled by client id: on a
room slow to answer, an edit typed right after opening could lose to a value
the room held, or take it over unseen. The graph does not race this way (its
keys are per operator); these two single-key values do.

Such an edit is now held the way the database copy is: read from and
announced at once, so the page shows it and an autosave carries it, and
written after the sync as a write that follows the room's state and replaces
it, which is what an edit means, so it yields to nothing. Once the document
has synced (or is not connecting) an edit goes into the document directly,
as before. With edits held rather than written, the map observer's cancelling
of a seed on a local write had nothing left to do, and goes.

Spec: an edit typed right after opening is not in the document before the
sync, is what the page shows while a co-editor's value arrives, and is what
the document holds after the sync; the settings edit the same; the listener
count test follows the edit taking the seed's place.

Co-Authored-By: Claude Fable 5.1 <[email protected]>

Report URL: https://github.com/apache/texera/actions/runs/36484545776

With regards,
GitHub Actions via GitBox

Reply via email to