The GitHub Actions job "Backport Approval Check" on 
texera.git/fix-8315-shared-nonshared-state has failed.
Run started by GitHub user Copilot (triggered by Copilot).

Head commit for run:
5ae4c9308b7a1ab049377007d3bbd0a6e24d64ed / Yang Zhang <[email protected]>
fix(workflow): mark a cleared content-meta key in the document instead of 
deleting it

Review follow-up on #8351, third round. A workflow opened or reloaded without
a value deleted the key from the shared map, and a deletion leaves nothing in
the room's state for a joining client to learn from: its first sync delivered
no change for the key, so the seed of a database copy the clearing had not
reached yet put the value back, for every client in the room.

Absence is explicit now: such a workflow marks the key cleared (null). The
mark reaches a joining client as a remote change, and the seed a workflow is
opened with yields to what the room put in the document, a co-editor's value
or that mark, while replacing anything else the document holds, a value this
client wrote before the reload included. Reads treat the mark as none, so the
getters fall back to the defaults and the content omits the key.

Spec: a co-editor's cleared mark keeps a database copy that still has the
definition out of the document; a workflow opened without settings into a
fresh room writes the mark, and one opened without them into a room that has
settings keeps the room's; a later reload without a definition marks, and
the content omits it. The sync helper sets the provider's synced flag as the
provider does, so a later reload's seed goes in at once, as it would live.

Co-Authored-By: Claude Fable 5.1 <[email protected]>

Report URL: https://github.com/apache/texera/actions/runs/36388629873

With regards,
GitHub Actions via GitBox

Reply via email to