The GitHub Actions job "Required Checks" on texera.git/main has succeeded. Run started by GitHub user github-merge-queue[bot] (triggered by github-merge-queue[bot]).
Head commit for run: b43d46520365a42e8a5df892520bead6b2fb6cfe / Xinyuan Lin <[email protected]> refactor(frontend): remove dead computing-unit modal leftovers (#8827) ### What changes were proposed in this PR? Removes two leftovers from `ComputingUnitCreateModalComponent`. **−2 lines.** There is no behaviour change. - `<ng-template #addComputeUnitModalTitle>`. The modal's title comes from `[nzTitle]="getCreateModalTitle()"`. Nothing else reads the template: there is no `@ViewChild`, no outlet, and neither of the two hosts that open the modal passes it. `nz-modal` only picks up its title/content/footer directives, never a plain `#ref` template. - The `selectedShmSize` field. The create payload builds `shmSize` from `shmSizeValue` / `shmSizeUnit`, which stay. ### History | | | | --- | --- | | **Introduced by** | #3315 (2025-03-13), "Add computing unit manager frontend": the title template. #3451 (2025-05-28), "Enable adjusting shared memory for the computing unit": `selectedShmSize` | | **Usage removed by** | #3400 (2025-05-26) switched the title to `getCreateModalTitle()`. #4331 (2026-04-09), "add full computing unit tab", dropped the field's last write and read. #6082 later moved both, still unread, into this shared component | The title template has been unused for sixteen months, and the field for six. ### Any related issues, documentation, discussions? Closes #8826 ### How was this PR tested? No new tests; no spec referenced either item. >From `frontend/`: - `npx ng test --watch=false --include='**/computing-unit-create-modal.component.spec.ts' --include='**/user-computing-unit.component.spec.ts' --include='**/computing-unit-selection.component.spec.ts'`: 3 files, 248 tests, all pass. The other two specs cover the modal's two hosts. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n "addComputeUnitModalTitle\|selectedShmSize" -- frontend # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Report URL: https://github.com/apache/texera/actions/runs/37421021842 With regards, GitHub Actions via GitBox
